Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-18783] Capped SDK version monkey patch for which --password is co... #211

Merged
merged 1 commit into from
Apr 7, 2015
Merged

[TIMOB-18783] Capped SDK version monkey patch for which --password is co... #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
4.0.0
4.0.0 (Unreleased)
-------------------
* Ripped out all authentication requirements. Analytics are now anonymous. Login and logout are no ops. [TIMOB-18711]
* Added support for generic Titanium SDK-level info [TIMOB-17836]
* Allow the colors to be controlled explicitly regardless if attached or detached from a TTY
* Fixed bug where abbreviated options without values passed in before the last argument being treated as a boolean [TIMOB-18067]
* Ripped out all authentication requirements. Analytics are now anonymous. Login and logout are no ops. [TIMOB-18711]
* Capped SDK version monkey patch for which --password is converted to --store-password for Android [TIMOB-18783]

3.4.2
3.4.2 (3/6/2015)
-------------------
* Fixed compatibility issues with Node 0.12 [TIMOB-18538]
* Added Node.js version check when using a Titanium SDK [TIMOB-18629]
Expand Down
2 changes: 1 addition & 1 deletion hooks/tisdk3fixes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ exports.init = function (logger, config, cli, appc) {
// there was a bug in 3.2.0 where the --store-password was being forced to
// --password when forking the correct SDK command with a SDK >= 3.2.0, so we
// need to reverse it
if (sdk && appc.version.gte(sdk, '3.2.0') && cli.argv.platform == 'android' && !cli.argv['store-password'] && cli.argv.password) {
if (sdk && appc.version.gte(sdk, '3.2.0') && appc.version.lt(sdk, '4.0.0') && cli.argv.platform === 'android' && !cli.argv['store-password'] && cli.argv.password) {
cli.argv['store-password'] = cli.argv.password;
}
});
Expand Down