Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PurgeTSS docs for Alloy integration #106

Merged
merged 17 commits into from
May 23, 2022
Merged

PurgeTSS docs for Alloy integration #106

merged 17 commits into from
May 23, 2022

Conversation

caspahouzer
Copy link
Contributor

Here are the docs for this PR

I integrated all docs from https://github.com/macCesar/purgeTSS, extended and changed to follow our doc guidelines.

This PR may not be approved until this PR is completely merged

@caspahouzer caspahouzer added the enhancement New feature or request label Mar 29, 2022
@caspahouzer caspahouzer marked this pull request as draft March 29, 2022 19:21
@caspahouzer caspahouzer marked this pull request as ready for review March 29, 2022 19:21
@m1ga
Copy link
Contributor

m1ga commented Mar 29, 2022

wouldn't it be better to link to https://github.com/macCesar/purgeTSS/releases in "whats new" and not include all the changelogs into titanium-docs? Otherwise we always have to create a new page when purgetss gets an update

@cb1kenobi
Copy link
Contributor

Agree with @m1ga, let's keep PurgeTSS release notes in PurgeTSS repo.

@caspahouzer
Copy link
Contributor Author

wouldn't it be better to link to https://github.com/macCesar/purgeTSS/releases in "whats new" and not include all the changelogs into titanium-docs? Otherwise we always have to create a new page when purgetss gets an update

Yes. It' so much less work.

Bildschirmfoto 2022-03-30 um 07 16 48

@caspahouzer
Copy link
Contributor Author

removed nearly all readme in favor of official https://purgetss.com/ docs

Bildschirmfoto 2022-04-18 um 08 39 07

@m1ga m1ga mentioned this pull request Apr 19, 2022
Open
@caspahouzer caspahouzer mentioned this pull request May 17, 2022
Closed
@caspahouzer
Copy link
Contributor Author

I've finished this PR. It's ready to merge as alloy 2.0.0 is released

cb1kenobi
cb1kenobi approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@cb1kenobi cb1kenobi merged commit 588ce94 into tidev:main May 23, 2022
@caspahouzer caspahouzer deleted the pr_purgeTSS_docs branch May 26, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caspahouzer @m1ga @cb1kenobi