Skip to content

Commit

Permalink
refactor(ios): remove deprecated properties on ipad popover
Browse files Browse the repository at this point in the history
    This removes the height, width, leftNavButton and rightNavButton properties that have been deprecated since sdk
    3.4.2

    BREAKING CHANGE: Removes deprecated ipad popover properties: height, width, leftNavButton and rightNavButton
  • Loading branch information
sgtcoolguy committed Dec 9, 2019
1 parent f63f721 commit 14cd341
Showing 1 changed file with 1 addition and 56 deletions.
57 changes: 1 addition & 56 deletions iphone/Classes/TiUIiPadPopoverProxy.m
@@ -1,6 +1,6 @@
/**
* Appcelerator Titanium Mobile
* Copyright (c) 2010-2014 by Appcelerator, Inc. All Rights Reserved.
* Copyright (c) 2010-2019 by Appcelerator, Inc. All Rights Reserved.
* Licensed under the terms of the Apache Public License
* Please see the LICENSE included with this distribution for details.
*/
Expand Down Expand Up @@ -129,61 +129,6 @@ - (void)setPassthroughViews:(id)args
}
}

- (void)setWidth:(id)value
{
ENSURE_SINGLE_ARG_OR_NIL(value, NSObject);
DebugLog(@"[WARN] Setting width on the popover directly is deprecated. Change the width property of the contentView property instead");

if (IS_NULL_OR_NIL(value)) {
poWidth = TiDimensionUndefined;
} else {
poWidth = TiDimensionFromObject(value);
}
[self replaceValue:value forKey:@"width" notification:NO];

if (popoverInitialized) {
TiThreadPerformOnMainThread(^{
[self updateContentSize];
},
NO);
}
}

- (void)setHeight:(id)value
{
ENSURE_SINGLE_ARG_OR_NIL(value, NSObject);
DebugLog(@"[WARN] Setting height on the popover directly is deprecated. Change the height property of the contentView property instead");

if (IS_NULL_OR_NIL(value)) {
poHeight = TiDimensionUndefined;
} else {
poHeight = TiDimensionFromObject(value);
}
[self replaceValue:value forKey:@"height" notification:NO];

if (popoverInitialized) {
TiThreadPerformOnMainThread(^{
[self updateContentSize];
},
NO);
}
}

- (void)setTitle:(id)item
{
DebugLog(@"[ERROR] Support for setting title on the popover directly is removed in 3.4.2");
}

- (void)setRightNavButton:(id)args
{
DebugLog(@"[ERROR] Support for setting rightNavButton on the popover directly is removed in 3.4.2");
}

- (void)setLeftNavButton:(id)args
{
DebugLog(@"[ERROR] Support for setting leftNavButton on the popover directly is removed in 3.4.2");
}

#pragma mark Public Methods

- (void)show:(id)args
Expand Down

0 comments on commit 14cd341

Please sign in to comment.