Skip to content

Commit

Permalink
Merge pull request #2378 from ayeung/timob-8518
Browse files Browse the repository at this point in the history
TIMOB-8518: Android: ImageView does not handle width or height set to Ti...
  • Loading branch information
Opie Cyrus committed Jun 13, 2012
2 parents 40ba370 + 1bf3fc2 commit 17e5821
Showing 1 changed file with 14 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -806,15 +806,27 @@ public void run()
public void processProperties(KrollDict d)
{
TiImageView view = getView();
View parentView = getParentView();

if (view == null) {
return;
}

if (d.containsKey(TiC.PROPERTY_WIDTH)) {
requestedWidth = TiConvert.toTiDimension(d, TiC.PROPERTY_WIDTH, TiDimension.TYPE_WIDTH);
if (TiC.LAYOUT_FILL.equals(d.getString(TiC.PROPERTY_WIDTH)) && parentView != null) {
// Use the parent's width when it's fill
requestedWidth = TiConvert.toTiDimension(parentView.getMeasuredWidth(), TiDimension.TYPE_WIDTH);
} else {
requestedWidth = TiConvert.toTiDimension(d, TiC.PROPERTY_WIDTH, TiDimension.TYPE_WIDTH);
}
}
if (d.containsKey(TiC.PROPERTY_HEIGHT)) {
requestedHeight = TiConvert.toTiDimension(d, TiC.PROPERTY_HEIGHT, TiDimension.TYPE_HEIGHT);
// Use the parent's height when it's fill
if (TiC.LAYOUT_FILL.equals(d.getString(TiC.PROPERTY_HEIGHT)) && parentView != null) {
requestedHeight = TiConvert.toTiDimension(parentView.getMeasuredHeight(), TiDimension.TYPE_HEIGHT);
} else {
requestedHeight = TiConvert.toTiDimension(d, TiC.PROPERTY_HEIGHT, TiDimension.TYPE_HEIGHT);
}
}

if (d.containsKey(TiC.PROPERTY_IMAGES)) {
Expand Down

0 comments on commit 17e5821

Please sign in to comment.