fix(ios): tab background color on iOS 15 when setting title color

Fixes TIMOB-28551
tidev · Nov 17, 2021 · 248763a · 248763a
1 parent 3a5153c
commit 248763a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/iphone/Classes/TiUITabGroup.m b/iphone/Classes/TiUITabGroup.m
@@ -375,8 +375,17 @@ - (void)setTabsBackgroundColor_:(id)value
   [tabBar setBarTintColor:[color color]];
 #if IS_SDK_IOS_15
   if ([TiUtils isIOSVersionOrGreater:@"15.0"]) {
+    // Update main tab bar's appearance.
     tabBar.standardAppearance.backgroundColor = [color color];
     tabBar.scrollEdgeAppearance.backgroundColor = [color color];
+
+    // We must also update each tab in case they override main tab bar's appearance.
+    id tabs = [[self proxy] valueForKey:@"tabs"];
+    if ([tabs isKindOfClass:[NSArray class]]) {
+      for (TiUITabProxy *tabProxy in (NSArray *)tabs) {
+        [tabProxy updateTabBarItem];
+      }
+    }
   }
 #endif
 }

diff --git a/iphone/Classes/TiUITabProxy.h b/iphone/Classes/TiUITabProxy.h
@@ -51,6 +51,7 @@
 - (void)handleDidFocus:(NSDictionary *)event;
 - (void)handleWillShowViewController:(UIViewController *)viewController animated:(BOOL)animated;
 - (void)handleDidShowViewController:(UIViewController *)viewController animated:(BOOL)animated;
+- (void)updateTabBarItem;
 
 @end
 

diff --git a/iphone/Classes/TiUITabProxy.m b/iphone/Classes/TiUITabProxy.m
@@ -658,6 +658,10 @@ - (void)updateTabBarItem
         UITabBarItemStateAppearance *selectedAppearance = appearance.stackedLayoutAppearance.selected;
         selectedAppearance.titleTextAttributes = @{ NSForegroundColorAttributeName : [activeTitleColor color] };
       }
+      TiColor *backgroundColor = [TiUtils colorValue:[tabGroup valueForKey:@"tabsBackgroundColor"]];
+      if (backgroundColor != nil) {
+        appearance.backgroundColor = [backgroundColor color];
+      }
       ourItem.standardAppearance = appearance;
       ourItem.scrollEdgeAppearance = appearance;
     } else {