Skip to content

Commit

Permalink
fix(ios): when building module test project, unzip via spawn to avoid…
Browse files Browse the repository at this point in the history
… max buffer error (#12100)

Fixes TIMOB-28142
  • Loading branch information
build committed Sep 18, 2020
1 parent 76b8d8e commit 345eee1
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions iphone/cli/commands/_buildModule.js
Original file line number Diff line number Diff line change
Expand Up @@ -891,12 +891,9 @@ iOSModuleBuilder.prototype.runModule = function runModule(next) {
);

// 5. unzip module to the tmp dir. Use native binary on macOS, as AdmZip doesn't support symlinks used in mac catalyst frameworks
exec(`unzip -o ${this.moduleZipPath} -d ${tmpProjectDir}`, (err, _stdout, _stderr) => {
if (err) {
return cb(err);
}
cb();
});
const proc = spawn('unzip', [ '-o', this.moduleZipPath, '-d', tmpProjectDir ]);
proc.once('error', err => cb(err));
proc.on('exit', () => cb());
},

function (cb) {
Expand Down

0 comments on commit 345eee1

Please sign in to comment.