[TIMOB-19859] Android: Deprecate Ti.Android.R.drawable

tidev · Nov 4, 2015 · 40a96fe · 40a96fe
1 parent 05289ff
commit 40a96fe
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/android/titanium/src/java/org/appcelerator/titanium/util/TiFileHelper.java b/android/titanium/src/java/org/appcelerator/titanium/util/TiFileHelper.java
@@ -167,6 +167,7 @@ public InputStream openInputStream(String path, boolean report)
 				if (TI_RESOURCE_PREFIX.equals(section)) {
 					is = TiFileHelper.class.getResourceAsStream("/org/appcelerator/titanium/res/drawable/" + resid + ".png");
 				} else if ("Sys".equals(section)) {
+				    Log.e(TAG, "Accessing Android system icons is deprecated. Instead copy to res folder.");
 					Integer id = systemIcons.get(resid);
 					if (id != null) {
 						is = Resources.getSystem().openRawResource(id);
@@ -407,6 +408,7 @@ public Drawable getTitaniumResource(Context context, String s) {
 					}
 				}
 			} else if ("Sys".equals(section)) {
+			    Log.e(TAG, "Accessing Android system icons is deprecated. Instead copy to res folder.");
 				Integer id = systemIcons.get(resid);
 				if (id != null) {
 					d = Resources.getSystem().getDrawable(id);

diff --git a/android/titanium/src/java/org/appcelerator/titanium/util/TiRHelper.java b/android/titanium/src/java/org/appcelerator/titanium/util/TiRHelper.java
@@ -64,6 +64,10 @@ protected static int getResource(String prefix, String path) throws ResourceNotF
 	}
 
 	protected static int lookupResource(String prefix, String path, String[] classAndFieldNames) throws ResourceNotFoundException {
+	    if (prefix.startsWith("android.R") && path.startsWith("drawable.")) {
+	        Log.w(TAG, "Using android.R.drawable is not recommended since they are changed/removed across Android versions. Instead copy images to res folder.");
+	    }
+
 		// Get the clsPrefixApplication if this is the first time
 		if (clsPrefixApplication == null)
 			clsPrefixApplication = TiApplication.getInstance().getApplicationInfo().packageName + ".R$";

diff --git a/apidoc/Titanium/Android/R.yml b/apidoc/Titanium/Android/R.yml
@@ -12,6 +12,9 @@ description: |
     See also: [android.R](http://developer.android.com/reference/android/R.html) in the
     Android Developer Reference.
 
+    Accessing drawables using Ti.Android.R.drawable is deprecated and not a recommended practice since the system provided drawables can be 
+    removed across Android versions. Prefer to copy the images to application res folder. 
+
 extends: Titanium.Proxy
 platforms: [android]
 createable: false
@@ -67,6 +70,8 @@ properties:
         Drawable resources. See 
         [R.drawable](http://developer.android.com/reference/android/R.drawable.html)
         in the Android Developer Reference.
+        Accessing drawables using Ti.Android.R.drawable is deprecated and not a recommended practice since the system provided 
+        drawables can be removed across Android versions. Prefer to copy the images to application res folder. 
     type: Object
     accessors: false
     permission: read-only