fix(ios): explicitly flush KrollPromises created internally and not e…

…xposed to JS
tidev · Jan 26, 2021 · 528a79c · 528a79c
1 parent 2704ec2
commit 528a79c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/iphone/Classes/TiUINavigationWindowProxy.m b/iphone/Classes/TiUINavigationWindowProxy.m
@@ -374,7 +374,7 @@ - (void)cleanNavStack
             TiWindowProxy *win = (TiWindowProxy *)[(TiViewController *)viewController proxy];
             [win setTab:nil];
             [win setParentOrientationController:nil];
-            [win close:nil];
+            [[win close:nil] flush];
           }
           // Remove navigation controller from parent controller
           [navController willMoveToParentViewController:nil];

diff --git a/iphone/Classes/TiUITabProxy.m b/iphone/Classes/TiUITabProxy.m
@@ -221,7 +221,7 @@ - (void)closeWindowProxy:(TiWindowProxy *)window animated:(BOOL)animated
   // for this to work right, we need to sure that we always have the tab close the window
   // and not let the window simply close by itself. this will ensure that we tell the
   // tab that we're doing that
-  [window close:nil]; // FIXME: How can we take the returned Promise and basically forward it's reject/resolve along?
+  [[window close:nil] flush]; // FIXME: How can we take the returned Promise and basically forward it's reject/resolve along?
   RELEASE_TO_NIL_AUTORELEASE(window);
   RELEASE_TO_NIL(windowController);
 }

diff --git a/iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m b/iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m
@@ -575,7 +575,7 @@ - (void)openOnUIThread:(NSArray *)args
       } else {
         args = [NSArray arrayWithObject:self];
       }
-      [tab openWindow:args];
+      [[tab openWindow:args] flush]; // TODO: release?
     } else if (isModal) {
       UIViewController *theController = [self hostingController];
       [self windowWillOpen];