[TIMOB-26115] Address review comments

tidev · Jul 11, 2018 · 55cfc96 · 55cfc96
1 parent ebecd89
commit 55cfc96
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/iphone/Classes/TiConsole.m b/iphone/Classes/TiConsole.m
@@ -44,28 +44,25 @@ - (void)timeEnd:(id)label
     [self logMessage:[logMessage componentsSeparatedByString:@" "] severity:@"warn"];
     return;
   }
-  double duration = [startTime timeIntervalSinceNow] * -1000;
+  NSTimeInterval duration = [startTime timeIntervalSinceNow] * -1000;
   NSString *logMessage = [NSString stringWithFormat:@"%@: %0.fms", label, duration];
   [self logMessage:[logMessage componentsSeparatedByString:@" "] severity:@"info"];
   [_times removeObjectForKey:label];
 }
 
 - (void)timeLog:(id)args
 {
-  NSString *label = [args objectAtIndex:0];
+  NSString *label = [args objectAtIndex:0] ?: @"default";
   NSArray *logData = [args count] > 1 ? [args subarrayWithRange:NSMakeRange(1, [args count] - 1)] : nil;
-  if (label == nil) {
-    label = @"default";
-  }
   NSDate *startTime = _times[label];
   if (startTime == nil) {
     NSString *logMessage = [NSString stringWithFormat:@"Label \"%@\" does not exist", label];
     [self logMessage:[logMessage componentsSeparatedByString:@" "] severity:@"warn"];
     return;
   }
-  double duration = [startTime timeIntervalSinceNow] * -1000;
+  NSTimeInterval duration = [startTime timeIntervalSinceNow] * -1000;
   NSString *logMessage = [NSString stringWithFormat:@"%@: %0.fms ", label, duration];
-  if ([logData count]) {
+  if ([logData count] > 0) {
     logMessage = [logMessage stringByAppendingString:[logData componentsJoinedByString:@" "]];
   }
   [self logMessage:[logMessage componentsSeparatedByString:@" "] severity:@"info"];