Skip to content

Commit

Permalink
Merge pull request #10065 from garymathews/TIMOB-26055
Browse files Browse the repository at this point in the history
[TIMOB-26055] Android: Handle injected build variables
  • Loading branch information
lokeshchdhry committed May 18, 2018
2 parents 59c1214 + 354ed97 commit 7d6543a
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion android/cli/commands/_build.js
Original file line number Diff line number Diff line change
Expand Up @@ -3885,8 +3885,15 @@ AndroidBuilder.prototype.generateAndroidManifest = function generateAndroidManif
this.androidLibraries.forEach(libraryInfo => {
const libraryManifestPath = path.join(libraryInfo.explodedPath, 'AndroidManifest.xml');
if (fs.existsSync(libraryManifestPath)) {
let libraryManifestContent = fs.readFileSync(libraryManifestPath).toString();

// handle injected build variables
// https://developer.android.com/studio/build/manifest-build-variables
libraryManifestContent = libraryManifestContent.replace('${applicationId}', this.appid); // eslint-disable-line no-template-curly-in-string

const libraryManifest = new AndroidManifest();
libraryManifest.load(libraryManifestPath);
libraryManifest.parse(libraryManifestContent);

// we don't want android libraries to override the <supports-screens> or <uses-sdk> tags
delete libraryManifest.__attr__;
delete libraryManifest['supports-screens'];
Expand Down

0 comments on commit 7d6543a

Please sign in to comment.