fix(android): reduce tableView updates (#13526)

tidev · Aug 19, 2023 · 911fa84 · 911fa84
1 parent d8b8d88
commit 911fa84
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/android/modules/ui/src/java/ti/modules/titanium/ui/TableViewProxy.java b/android/modules/ui/src/java/ti/modules/titanium/ui/TableViewProxy.java
@@ -128,6 +128,11 @@ static public TableViewSectionProxy processSection(Object obj)
 	 */
 	@Kroll.method
 	public void appendRow(Object rows, @Kroll.argument(optional = true) KrollDict animation)
+	{
+		appendRowInternal(rows, animation, false);
+	}
+
+	private void appendRowInternal(Object rows, KrollDict animation, boolean internalUpdate)
 	{
 		final List<TableViewRowProxy> rowList = new ArrayList<>();
 
@@ -190,7 +195,11 @@ public void appendRow(Object rows, @Kroll.argument(optional = true) KrollDict an
 
 		// Allow updating rows after iteration.
 		shouldUpdate = true;
-		update();
+
+		// don't update when coming from setData loop
+		if (!internalUpdate) {
+			update();
+		}
 	}
 
 	/**
@@ -508,7 +517,7 @@ public void setData(Object[] data)
 				final TableViewRowProxy row = (TableViewRowProxy) d;
 
 				// Handle TableViewRow.
-				appendRow(row, null);
+				appendRowInternal(row, null, true);
 
 			} else if (d instanceof Object[]) {
 				setData((Object[]) d);
@@ -519,7 +528,7 @@ public void setData(Object[] data)
 
 				// Handle TableViewRow dictionary.
 				row.handleCreationDict(new KrollDict((HashMap) d));
-				appendRow(row, null);
+				appendRowInternal(row, null, true);
 
 			} else if (d instanceof TableViewSectionProxy) {
 				final TableViewSectionProxy section = (TableViewSectionProxy) d;
@@ -531,7 +540,6 @@ public void setData(Object[] data)
 
 		// Allow updating rows after iteration.
 		shouldUpdate = true;
-
 		update();
 	}