[TIMOB-8295] Ensure Ti.UI.View.children is a copy, not a live reference.

tidev · Apr 28, 2012 · a19c905 · a19c905
1 parent fb1ee99
commit a19c905
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/iphone/Classes/TiViewProxy.m b/iphone/Classes/TiViewProxy.m
@@ -42,15 +42,18 @@ -(void)setVzIndex:(int)newZindex
 @synthesize children;
 -(NSArray*)children
 {
+    NSArray* copy = nil;
+
 	pthread_rwlock_rdlock(&childrenLock);
 	if (windowOpened==NO && children==nil && pendingAdds!=nil)
 	{
-		NSArray *copy = [pendingAdds mutableCopy];
-		pthread_rwlock_unlock(&childrenLock);
-		return [copy autorelease];
+		copy = [pendingAdds mutableCopy];
 	}
+    else {
+        copy = [children mutableCopy];
+    }
 	pthread_rwlock_unlock(&childrenLock);
-	return children;
+	return [copy autorelease];
 }
 
 -(void)setVisible:(NSNumber *)newVisible withObject:(id)args