fix(android): address review feedback

tidev · Apr 3, 2020 · b227ebd · b227ebd
1 parent 436b381
commit b227ebd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/android/modules/android/src/java/org/appcelerator/titanium/proxy/TiActivityWindowProxy.java b/android/modules/android/src/java/org/appcelerator/titanium/proxy/TiActivityWindowProxy.java
@@ -1,6 +1,6 @@
 /**
  * Appcelerator Titanium Mobile
- * Copyright (c) 2009-2012 by Appcelerator, Inc. All Rights Reserved.
+ * Copyright (c) 2009-Present by Appcelerator, Inc. All Rights Reserved.
  * Licensed under the terms of the Apache Public License
  * Please see the LICENSE included with this distribution for details.
  */
@@ -39,15 +39,14 @@ public void setView(TiUIView view)
 	protected void handleClose(@NonNull KrollDict options)
 	{
 		Log.d(TAG, "handleClose", Log.DEBUG_MODE);
+		opened = false;
 		fireEvent("close", null);
 
 		if (view != null) {
 			((TiUIActivityWindow) view).close();
 		}
 
 		releaseViews();
-		opened =
-			false; // FIXME: This will lead to odd case of a close listener querying isCLosed and getting false! Set to false above? fire event after?
 	}
 
 	@Override

diff --git a/android/modules/ui/src/java/ti/modules/titanium/ui/TabGroupProxy.java b/android/modules/ui/src/java/ti/modules/titanium/ui/TabGroupProxy.java
@@ -517,7 +517,7 @@ protected void handleClose(@NonNull KrollDict options)
 			activity.finish();
 		}
 
-		// TODO: Does this ever fire the close event?!
+		// NOTE: this does not directly fire the close event, but is fired by closeFromActivity()
 	}
 
 	@Override