Merge pull request #5289 from cb1kenobi/timob-16214_3_2_X

[TIMOB-16214] Added a try/catch to detect bad module jar files.
tidev · Feb 4, 2014 · c34c238 · c34c238
2 parents 374e9b9 + 8a4fcba
commit c34c238
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/android/cli/commands/_build.js b/android/cli/commands/_build.js
@@ -1479,12 +1479,17 @@ AndroidBuilder.prototype.validate = function validate(logger, config, cli) {
 
 					if (module.jarFile) {
 						// read in the bindings
-						module.bindings = this.getNativeModuleBindings(module.jarFile);
-						if (!module.bindings) {
-							logger.error(__('Module %s version %s is missing bindings json file', module.id.cyan, (module.manifest.version || 'latest').cyan) + '\n');
+						try {
+							module.bindings = this.getNativeModuleBindings(module.jarFile);
+							if (!module.bindings) {
+								logger.error(__('Module %s version %s is missing bindings json file', module.id.cyan, (module.manifest.version || 'latest').cyan) + '\n');
+								process.exit(1);
+							}
+							bindingsHashes.push(hash(JSON.stringify(module.bindings)));
+						} catch (ex) {
+							logger.error(__('The module "%s" has an invalid jar file: %s', module.id, module.jarFile) + '\n');
 							process.exit(1);
 						}
-						bindingsHashes.push(hash(JSON.stringify(module.bindings)));
 					}
 
 					this.nativeLibModules.push(module);