fix(ios): animating view width/height from zero

Fixes TIMOB-27236
tidev · Jun 14, 2021 · df7c106 · df7c106
1 parent 4914dca
commit df7c106
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewProxy.m b/iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewProxy.m
@@ -1318,8 +1318,7 @@ - (BOOL)viewInitialized
 
 - (BOOL)viewReady
 {
-  return view != nil && !CGRectIsEmpty(view.bounds) && !CGRectIsNull(view.bounds) &&
-      [view superview] != nil;
+  return (view != nil) && ([view superview] != nil);
 }
 
 - (BOOL)windowHasOpened

diff --git a/tests/Resources/ti.ui.view.test.js b/tests/Resources/ti.ui.view.test.js
@@ -699,6 +699,31 @@ describe('Titanium.UI.View', function () {
 		win.open();
 	});
 
+	// On iOS, the animation's 'complete' event used to never fire. See: TIMOB-27236
+	it('animate width/height from zero', function (finish) {
+		win = Ti.UI.createWindow({ backgroundColor: 'white' });
+		const view = Ti.UI.createView({
+			backgroundColor: 'orange',
+			top: 0,
+			left: 0,
+			width: 0,
+			height: 0,
+		});
+		win.add(view);
+		win.addEventListener('open', () => {
+			const animation = Ti.UI.createAnimation({
+				duration: 250,
+				width: win.size.width,
+				height: win.size.height,
+			});
+			animation.addEventListener('complete', () => {
+				finish();
+			});
+			view.animate(animation);
+		});
+		win.open();
+	});
+
 	it.windowsBroken('convertPointToView', function (finish) {
 		win = Ti.UI.createWindow();
 		const a = Ti.UI.createView({ backgroundColor: 'red' });