Merge pull request #8051 from ashcoding/TIMOB-20415_5_4_X

(5_4_X)[TIMOB-20415] Android: HttpClient Basic Auth Infinite loop fix

android/modules/network/src/java/ti/modules/titanium/network/TiAuthenticator.java

@@ -8,6 +8,10 @@ public class TiAuthenticator extends Authenticator {
     String user;
     String password;
 
+    // MAX_RETRY_COUNT is set to 3 retries
+    private final static int MAX_RETRY_COUNT = 3;
+    private int retryCount = 0;
+
     public TiAuthenticator(String user, String password) {
         super();
         this.domain = null;
@@ -27,9 +31,20 @@ public PasswordAuthentication getPasswordAuthentication() {
         if (domain != null && !domain.isEmpty()) {
             user = domain + "\\" + user;
         }
-        if (password != null) {
-            return new PasswordAuthentication(user, password.toCharArray());
+        // This is for TIMOB-20415 with the solution from Android's Issue Tracker,
+        // https://code.google.com/p/android/issues/detail?id=7058
+        // The Authenticator will do a retry when when it gets a response from the
+        // server that the credentials provided is incorrect. When this happens,
+        // getPasswordAuthentication() is called again for as long it is incorrect.
+        // In order to stop the loop, the Authenticator needs to return a null
+        // object to indicate that the retry needs to stop. Hence, we have a MAX_RETRY_COUNT.
+        if (retryCount < MAX_RETRY_COUNT) {
+            retryCount++;
+            if (password != null) {
+                return new PasswordAuthentication(user, password.toCharArray());
+            }
+            return new PasswordAuthentication(user, null);
         }
-        return new PasswordAuthentication(user, null);
+        return null;
     }
 }