[TIMOB-25963] Android: Improve KrollRuntime error output - Separate Java/JS stacks #10012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing is thrown, still gather JS stack to show/log. Remove unnecessary code for grabbing stack trace as the Error object and bare string handling achieves that.
Generated by 🚫 dangerJS |
garymathews
pushed a commit
to garymathews/titanium_mobile
that referenced
this pull request
Apr 25, 2018
garymathews
pushed a commit
to garymathews/titanium_mobile
that referenced
this pull request
Apr 25, 2018
garymathews
pushed a commit
to garymathews/titanium_mobile
that referenced
this pull request
Apr 26, 2018
garymathews
pushed a commit
to garymathews/titanium_mobile
that referenced
this pull request
Apr 26, 2018
garymathews
pushed a commit
to garymathews/titanium_mobile
that referenced
this pull request
Apr 26, 2018
|
Closing in favor of #10003 - Gary's taken the improvements from this PR and we should drive that one to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25963
Description:
Hijack of #10003