Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26084] (7_2_X) Removed project directory from analytics events. #10086

Merged
merged 1 commit into from
Jun 4, 2018
Merged

[TIMOB-26084] (7_2_X) Removed project directory from analytics events. #10086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion android/cli/commands/_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,7 +1811,6 @@ AndroidBuilder.prototype.doAnalytics = function doAnalytics(next) {
}

cli.addAnalyticsEvent(eventName, {
dir: cli.argv['project-dir'],
name: cli.tiapp.name,
publisher: cli.tiapp.publisher,
url: cli.tiapp.url,
Expand Down
23 changes: 11 additions & 12 deletions android/cli/commands/_buildModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
/**
* Android module build command.
*
* @module cli/_buildModule
*
* @copyright
* Copyright (c) 2014-2017 by Appcelerator, Inc. All Rights Reserved.
*
* @license
* Licensed under the terms of the Apache Public License
* Please see the LICENSE included with this distribution for details.
*/
* Android module build command.
*
* @module cli/_buildModule
*
* @copyright
* Copyright (c) 2014-2018 by Appcelerator, Inc. All Rights Reserved.
*
* @license
* Licensed under the terms of the Apache Public License
* Please see the LICENSE included with this distribution for details.
*/

'use strict';

Expand Down Expand Up @@ -362,7 +362,6 @@ AndroidModuleBuilder.prototype.doAnalytics = function doAnalytics(next) {
eventName = 'android.' + cli.argv.type;

cli.addAnalyticsEvent(eventName, {
dir: cli.argv['project-dir'],
name: manifest.name,
publisher: manifest.author,
appid: manifest.moduleid,
Expand Down
3 changes: 1 addition & 2 deletions cli/lib/creators/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Logic for creating new Titanium apps.
*
* @copyright
* Copyright (c) 2014-2015 by Appcelerator, Inc. All Rights Reserved.
* Copyright (c) 2014-2018 by Appcelerator, Inc. All Rights Reserved.
*
* @license
* Licensed under the terms of the Apache Public License
Expand Down Expand Up @@ -209,7 +209,6 @@ AppCreator.prototype.run = function run(callback) {
tasks.push(function (next) {
// send the analytics
this.cli.addAnalyticsEvent('project.create.mobile', {
dir: projectDir,
name: argv.name,
publisher: projectConfig.publisher,
url: projectConfig.url,
Expand Down
3 changes: 1 addition & 2 deletions cli/lib/creators/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Logic for creating new Titanium modules.
*
* @copyright
* Copyright (c) 2014-2017 by Appcelerator, Inc. All Rights Reserved.
* Copyright (c) 2014-2018 by Appcelerator, Inc. All Rights Reserved.
*
* @license
* Licensed under the terms of the Apache Public License
Expand Down Expand Up @@ -192,7 +192,6 @@ ModuleCreator.prototype.run = function run(callback) {
tasks.push(function (next) {
// send the analytics
this.cli.addAnalyticsEvent('project.create.module', {
dir: projectDir,
name: variables.moduleName,
author: variables.author,
moduleid: variables.moduleId,
Expand Down
3 changes: 1 addition & 2 deletions iphone/cli/commands/_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* @module cli/_build
*
* @copyright
* Copyright (c) 2009-2017 by Appcelerator, Inc. All Rights Reserved.
* Copyright (c) 2009-2018 by Appcelerator, Inc. All Rights Reserved.
*
* @license
* Licensed under the terms of the Apache Public License
Expand Down Expand Up @@ -2329,7 +2329,6 @@ iOSBuilder.prototype.doAnalytics = function doAnalytics() {
}

cli.addAnalyticsEvent(eventName, {
dir: cli.argv['project-dir'],
name: this.tiapp.name,
publisher: this.tiapp.publisher,
url: this.tiapp.url,
Expand Down
23 changes: 11 additions & 12 deletions iphone/cli/commands/_buildModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
/**
* iOS module build command.
*
* @module cli/_buildModule
*
* @copyright
* Copyright (c) 2014-2017 by Appcelerator, Inc. All Rights Reserved.
*
* @license
* Licensed under the terms of the Apache Public License
* Please see the LICENSE included with this distribution for details.
*/
* iOS module build command.
*
* @module cli/_buildModule
*
* @copyright
* Copyright (c) 2014-2018 by Appcelerator, Inc. All Rights Reserved.
*
* @license
* Licensed under the terms of the Apache Public License
* Please see the LICENSE included with this distribution for details.
*/

'use strict';

Expand Down Expand Up @@ -126,7 +126,6 @@ iOSModuleBuilder.prototype.doAnalytics = function doAnalytics() {
eventName = 'ios.' + cli.argv.type;

cli.addAnalyticsEvent(eventName, {
dir: this.cli.argv['project-dir'],
name: this.moduleName,
publisher: this.manifest.author,
appid: this.moduleId,
Expand Down