Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some local timings for iOS build. The slowest part is clearly the xcodebuild invocation. I think moving to pre-compiled frameworks may be able to help speed that up somewhat.
However, I did see that producing the logo set and copying JS files were being run in series when they could be run in parallel (and those two are the other largest chunks of time in our build).
So here are my totally unscientific timings here on clean builds of the mocha test app:
master: 35-38s
next: 30-31s
next w/ framework (#10218): 27-31s
next w/ parallel-build (this PR): 24-29s
next w/ framework & parallel-build: 22-23s
Specifically this PR tries to run writing the app props, handling JS files, copying CSS files and handling the images/resource files in parallel now (where before we ran it all in series).
We still run the image manipulations/functions and copying resources in series. The big win here is running all of that in parallel with the JS file copying/parsing/writing as we shave off a few valuable seconds.