Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26391](7_4_X) : iOS App randomly freezes on iOS 12 beta when using built-in JSCore #10361

Closed
wants to merge 1 commit into from
Closed

[TIMOB-26391](7_4_X) : iOS App randomly freezes on iOS 12 beta when using built-in JSCore #10361

wants to merge 1 commit into from

Conversation

vijaysingh-axway
Copy link
Contributor

@sgtcoolguy
Copy link
Contributor

I believe that this should likely be rejected? Sounds like Jan is trying to look into a better location for the unprotect call?

Also, I'm not 100% certain that the issue for "freezes" is necessarily an GC issue. If we mess up GC (protect/unprotect) that should cause a crash. If an app is "freezing" it's likely due to a deadlock or some threading issue. Perhaps we should roll back the change we made to timers to flip the "wait" boolean flag when it invoked the block on the main thread (our first speculative fix for the freeze/crash ticket)?

@vijaysingh-axway
Copy link
Contributor Author

Agreed. It is holding the proxy for lifetime. So it can cause some different issue. I will revert the changes of PR-10327. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann Awaiting requested review from janvennemann

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

Assignees
No one assigned
Labels
ios no tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vijaysingh-axway @sgtcoolguy @build