-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-26391](7_4_X) Improve proxy protection logic #10370
Conversation
Using the existing protect/unprotect methods caused unwanted side effects. This introduces two similar methods for the sole purpose of safeguarding the JS object during our proxy creation flow.
Both apps are working fine at my end. |
Two methods which you have introduced-
Only difference I can see is updating location of bool ‘gcSafeguarded’ and ‘protecting’ in theses functions. Is bool value updating location is cause of some issue? |
Both methods basically do the same, yes. The reason i introduced them is because the are operating on another flag. We use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed.
Generated by 🚫 dangerJS |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26391
Optional Description:
Using the existing protect/unprotect methods caused unwanted side effects. This introduces two similar methods for the sole purpose of safeguarding the JS object during our proxy creation flow.