TIMOB-4260 add support for leftView and rightView for map annotation #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private ImageView leftImage; | ||
| private ImageView rightImage; | ||
| private TiCompositeLayout leftPane; | ||
| private TiCompositeLayout rightPane; |
There was a problem hiding this comment.
Would it be more efficient to use a generic "View" here, and assign the Image / custom View instead of having a wrapper layout?
|
functional test okay |
billdawson
added a commit
that referenced
this pull request
Jun 6, 2011
TIMOB-4260 add support for leftView and rightView for map annotation
jpl-mac
referenced
this pull request
in jpl-mac/titanium_mobile
Jul 17, 2012
Reviewer: DaveC Depends on PR Macadamian#105 Also fixed in this patch TIMOB-9545 BlackBerry: Implement Proxy This patch implements the fireEvent functionality and moves it's implementation to TiProxy along with add/removeEventListener to match the documented structure and have them inherited by all inherited Titanium types Changelog: - framework path implemented for fireEvent - Added EventPair struct to store the event container and handler for an event - Track events in the NativeObject class - Moved implementation to NativeObject and tested that event handling works well - Made the nextEventId to be global for all events of the system and not per NativeObject - moved fireEvent, add/removeEventListener to TiProxy - applied changes to all NativeObjects that currently have event handling - added support to delete the static singleton instances in Logger and String interfaces - removed compiler warnings in NativeControlObject and NativeObject - No apidoc needed, all of Proxy is now implemented and inherited in all other modules' yml Tests: Tested on simulator - add event listener for known event on objects that already handle events - then call fireEvent with a hardcoded event ==> verified that the event listener is invoked, events can also be chained in that way *NOTE: also tested with custom events, but these are currently not supported and support will need to be added as a separate task. Jira issue created https://jira.appcelerator.org/browse/TIMOB-9980
jpl-mac
referenced
this pull request
in jpl-mac/titanium_mobile
Jul 18, 2012
TIMOB-9971: BlackBerry: Complete 'remove' method in UI View
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.