Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): hide radio buttons OptionDialog #10645

Merged
merged 10 commits into from
Apr 25, 2019
Merged

feat(android): hide radio buttons OptionDialog #10645

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a79d0d4
remove radiobuttons in optiondialog
m1ga Jan 23, 2019
ef6d307
use selectedIndex
m1ga Jan 25, 2019
218c906
docs(android): update selectedIndex description
garymathews Mar 1, 2019
a829d8c
Merge branch 'master' into optiondialog
garymathews Mar 1, 2019
63a8879
Merge branch 'master' into optiondialog
ssjsamir Mar 4, 2019
4177aae
Merge branch 'master' into optiondialog
ssjsamir Mar 5, 2019
5cee11e
Merge branch 'master' into optiondialog
ssjsamir Apr 5, 2019
e20561d
Merge branch 'master' into optiondialog
keerthi1032 Apr 22, 2019
eaca331
Merge branch 'master' into optiondialog
lokeshchdhry Apr 23, 2019
869fb55
Merge branch 'master' into optiondialog
lokeshchdhry Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 17 additions & 7 deletions android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,23 @@ public void processProperties(KrollDict d)

private void processOptions(String[] optionText, int selectedIndex)
{
getBuilder().setSingleChoiceItems(optionText, selectedIndex, new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int which)
{
handleEvent(which);
hide(null);
}
});
if (selectedIndex != -1) {
getBuilder().setSingleChoiceItems(optionText, selectedIndex, new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int which)
{
handleEvent(which);
hide(null);
}
});
} else {
getBuilder().setItems(optionText, new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int which)
{
handleEvent(which);
hide(null);
}
});
}
}

private void processButtons(String[] buttonText)
Expand Down
3 changes: 2 additions & 1 deletion apidoc/Titanium/UI/OptionDialog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ properties:
platforms: [android, iphone, ipad]

- name: selectedIndex
summary: Defines the default selected option.
summary: Defines the default selected option. Since `8.1.0`, if not defined or -1 it will show a
normal list instead of radio buttons.
platforms: [android]
type: Number
availability: creation
Expand Down