Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_0_X): Fixed bug where setting SearchBar "hintText" after window open crashes as of 7.0.0 #10849

Merged
merged 3 commits into from
Apr 23, 2019
Merged

fix(android)(8_0_X): Fixed bug where setting SearchBar "hintText" after window open crashes as of 7.0.0 #10849

merged 3 commits into from
Apr 23, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 8.0.1 milestone Apr 13, 2019
@build build requested a review from a team April 13, 2019 02:19
@build
Copy link
Contributor

build commented Apr 13, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3025 tests are passing.

Generated by 🚫 dangerJS against bfbdf0f

sgtcoolguy
sgtcoolguy approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments on #10848

@keerthi1032
Copy link
Contributor

FR passed. Searchbar did not crash and works as expected.
Test Enviornment:
Operating System
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Node.js
Node.js Version = 8.9.1
npm Version = 5.5.1
Titanium CLI
CLI Version = 5.1.1
APPC CLI =7.0.11-70X.1
Titanium SDK
SDK Version = local 8.0.1.v20190423101725 and local master 8.1.0.v20190412182932
Device=Oneplus 5t android 9,samsung s5 android 6
Emulator =pixel 2xl android 9,nexus android 6

@keerthi1032 keerthi1032 merged commit b0d0221 into tidev:8_0_X Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @keerthi1032 @sgtcoolguy