Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_1_X): File.read().text wrongly returns null for JSON files on Android Q #10955

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

jquick-axway
Copy link
Contributor

…on Android Q

- Modified Ti.Blob "text" property to always return text even if its a binary type, like iOS.
- Modified Ti.Blob toString() method to only return blob's text if mimetype is a known text type, like how "text" property used to work.
@build
Copy link
Contributor

build commented Jun 10, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3613 tests are passing.
(There are 464 tests skipped)

Generated by 🚫 dangerJS against 2f4a9eb

@lokeshchdhry
Copy link
Contributor

FR Passed.

Studio Ver: 5.1.3.201905231615
SDK Ver: 8.1.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 10.2.1
Appc NPM: 4.2.13
Appc CLI: 7.0.12-70X.4
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.10
Node Ver: 8.15.1
NPM Ver: 6.4.1
Java Ver: 10.0.2
Emulator: ⇨ google Android SDK built for x86 (Android 10)

@lokeshchdhry lokeshchdhry merged commit b7d56e3 into tidev:8_1_X Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants