Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): exclude all frameworks from optimizing files step (8_1_X) #10996

Merged
merged 6 commits into from
Aug 20, 2019
Merged

fix(ios): exclude all frameworks from optimizing files step (8_1_X) #10996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
336d06d
fix: exclude all frameworks from optimizing files step
janvennemann May 22, 2019
2f7841a
use proper regex
janvennemann May 23, 2019
a2301f2
Merge branch '8_1_X' into TIMOB-27097-8_1_X
sgtcoolguy Jul 16, 2019
cf0dc54
Merge branch '8_1_X' into TIMOB-27097-8_1_X
Aug 20, 2019
361d2cc
Merge branch '8_1_X' into TIMOB-27097-8_1_X
Aug 20, 2019
c62f535
Merge branch '8_1_X' into TIMOB-27097-8_1_X
Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion iphone/cli/commands/_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6439,7 +6439,7 @@ iOSBuilder.prototype.optimizeFiles = function optimizeFiles(next) {
}
}
});
}(this.xcodeAppDir, /^(PlugIns|Watch|TitaniumKit\.framework)$/i));
}(this.xcodeAppDir, /^(PlugIns|Watch|.+\.framework)$/i));

parallel(this, [
function (next) {
Expand Down
2 changes: 1 addition & 1 deletion iphone/cli/hooks/frameworks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ class FrameworkIntegrator {
isa: 'PBXBuildFile',
fileRef: fileRefUuid,
fileRef_comment: frameworkPackageName,
settings: { ATTRIBUTES: [ 'CodeSignOnCopy' ] }
settings: { ATTRIBUTES: [ 'CodeSignOnCopy', 'RemoveHeadersOnCopy' ] }
};
this._xobjs.PBXBuildFile[embeddedBuildFileUuid + '_comment'] = frameworkPackageName + ' in Embed Frameworks';

Expand Down