Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): regression in incremental device builds #11023

Merged
merged 8 commits into from
Jul 12, 2019
Merged

fix(ios): regression in incremental device builds #11023

merged 8 commits into from
Jul 12, 2019

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27202

Fixes a regression in incremental device builds that caused missing entries of encrypted JS files in the index.json used in our require.

@janvennemann janvennemann added this to the 8.2.0 milestone Jul 3, 2019
@janvennemann janvennemann mentioned this pull request Jul 3, 2019
Merged
@build
Copy link
Contributor

build commented Jul 3, 2019 •
edited

Warnings
⚠️

cli/lib/tasks/process-js-task.js#L157 - cli/lib/tasks/process-js-task.js line 157 – Avoid calling back inside of a promise. (promise/no-callback-in-promise)
⚠️

cli/lib/tasks/process-js-task.js#L164 - cli/lib/tasks/process-js-task.js line 164 – Avoid calling back inside of a promise. (promise/no-callback-in-promise)
Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3727 tests are passing.
(There are 470 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against e958e74

sgtcoolguy
sgtcoolguy approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not do FR

@ssekhri
Copy link

ssekhri commented Jul 9, 2019

FR Passed. Incremental builds working fine for iOS.

@sgtcoolguy sgtcoolguy merged commit 7993e9d into tidev:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@janvennemann @build @ssekhri @sgtcoolguy @ssjsamir @lokeshchdhry