Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): set navigation controller’s background color #11184

Merged
merged 8 commits into from
Sep 5, 2019
Merged

fix(ios): set navigation controller’s background color #11184

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bcb501f
fix(ios): set navigation controller’s background color
vijaysingh-axway Aug 28, 2019
f8dfc51
fix(ios): iOS 13 check applied
vijaysingh-axway Aug 30, 2019
49282e4
fix(ios): background color set for navigation controller in tabgroup
vijaysingh-axway Sep 3, 2019
aa5535f
Merge branch 'master' into TIMOB-27263
vijaysingh-axway Sep 3, 2019
408ec80
Merge branch 'master' into TIMOB-27263
ssjsamir Sep 4, 2019
be0a77e
Merge branch 'master' into TIMOB-27263
lokeshchdhry Sep 5, 2019
ba97fdb
fix(ios): Supported barColor in iOS 13
vijaysingh-axway Sep 5, 2019
cce212c
Merge branch 'master' into TIMOB-27263
lokeshchdhry Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions iphone/Classes/TiUINavigationWindowProxy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ - (void)navigationController:(UINavigationController *)navigationController will
[theWindow windowWillOpen];
[theWindow windowDidOpen];
}
navController.view.backgroundColor = theWindow.view.backgroundColor;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like a workaround, since thats not necessary natively. Can you please go through the view tree and check the differences between native views / VC's?

}

- (void)navigationController:(UINavigationController *)navigationController didShowViewController:(UIViewController *)viewController animated:(BOOL)animated
Expand Down