Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): support generic apple certificates #11188

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

ewanharris
Copy link
Collaborator

If passed in the name/team ID variant, we make a best attempt to map it back to the fullname variant of cert type/name/team ID. It's possible that we cant figure out the correct name (in the case where the name matches both the iOS cert and Apple cert), in which case we will error and prompt for the correct value.

Closes TIMOB-27358

JIRA: https://jira.appcelerator.org/browse/TIMOB-27358

Requires tidev/ioslib/pull/93

I need to fully verify that this doesn't break any of the signing of extensions.

@build build added this to the 8.2.0 milestone Aug 29, 2019
@build
Copy link
Contributor

build commented Aug 29, 2019

Messages
📖

✅ All tests are passing
Nice one! All 2257 tests are passing.
(There are 227 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Dependencies with modified semantic versioning:

  • ioslib - from ^1.7.10 to ^1.7.12

Generated by 🚫 dangerJS against 31220e0

If passed in the name/team ID variant, we make a best attempt to map it back to the fullname variant of cert type/name/team ID. It's possible that we cant figure out the correct name (in the case where the name matches both the iOS cert and Apple cert), in which case we will error and prompt for the correct value.

Closes TIMOB-27358
@ssjsamir ssjsamir self-requested a review September 3, 2019 10:33
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, able to use generic apple certificates when building to device and when distributing to the app store.

Test Environment

MacOS Mojave version 10.14.4
Xcode 11 beta 5
Node.js ^8.11.1
iPhone 8 plus sim (13.0)
"NPM":"4.2.14","CLI":"7.1.1-master.2"

@sgtcoolguy sgtcoolguy merged commit ed03d26 into tidev:master Sep 3, 2019
@ewanharris ewanharris deleted the TIMOB-27358 branch August 31, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants