-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): guard source property and removed NSNull if it is nil #11243
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FR Failed - I had it run for the first time and it worked as it should but when I tried for a number of times after the first it failed for all the attempts. I followed the steps in the video from the attachment (https://jira.appcelerator.org/browse/TIMOB-27354) Test Environment
|
FR Passed. Studio Ver: 5.1.4.201909061933 |
waiting to merge so that issue seen by @Dankyi can be verified. |
FR Passed - "First/Second app on resume from url: undefined" prompt didn't showed up in all the tests I run. Test Environment:
|
https://jira.appcelerator.org/browse/TIMOB-27354