Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): hide dimming view #11263

Merged
merged 4 commits into from Oct 10, 2019
Merged

fix(ios): hide dimming view #11263

merged 4 commits into from Oct 10, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.3.0 milestone Oct 4, 2019
@build build requested a review from a team October 4, 2019 22:36
@build
Copy link
Contributor

build commented Oct 4, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4122 tests are passing.
(There are 469 skipped tests not included in that total)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against e0e6387

janvennemann
janvennemann approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are looking good, approved!

@Dankyi
Copy link

Dankyi commented Oct 7, 2019

FR Passed:
For the ListView test case, it passed in SDK version 8.2.1 and 8.3.0
For the TableView test case, it passed in SDK version 8.2.1 and 8.3.0

Test Environment:

Studio Ver:     5.1.4.201909061933
OS Ver:         10.14.5
Xcode Ver:      Xcode 10.3
Appc NPM:       4.2.15
Appc CLI:       7.1.1
Daemon Ver:     1.1.3
Ti CLI Ver:     5.2.1
Alloy Ver:      1.14.1
Node Ver:       10.16.3
NPM Ver:        6.9.0
Java Ver:       1.8.0_162

Device:
iOS Version 13.0
iOS Version 12.1

@ssaddique ssaddique merged commit 3d492b7 into tidev:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vijaysingh-axway @build @Dankyi @janvennemann @ssaddique @ewanharris