feat(android): semantic colors and night mode #11301

drauggres · 2019-10-29T11:58:20Z

generate color resources from semantic.colors.json
add Ti.UI.Android.nightModeStatus API
add Ti.UI.Android.MODE_NIGHT_* constants

JIRA: https://jira.appcelerator.org/browse/TIMOB-27501

Sample app:
ewanharris/darkmode-example#1

if (OS_ANDROID) {
	const mode = Ti.UI.Android.nightModeStatus;
	if (mode === Ti.UI.Android.MODE_NIGHT_YES) {
		Ti.UI.semanticColorType = Ti.UI.SEMANTIC_COLOR_TYPE_DARK;
	} else {
		Ti.UI.semanticColorType = Ti.UI.SEMANTIC_COLOR_TYPE_LIGHT;
	}
}

build · 2019-10-29T12:03:49Z

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	✅ All tests are passing Nice one! All 6554 tests are passing. (There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against b281e24

hansemannn · 2019-10-29T17:22:25Z

android/modules/ui/src/java/ti/modules/titanium/ui/android/AndroidModule.java

+	@Kroll.constant
+	public static final int MODE_NIGHT_YES = Configuration.UI_MODE_NIGHT_YES;
+	@Kroll.constant
+	public static final int MODE_NIGHT_UNDEFINED = Configuration.UI_MODE_NIGHT_UNDEFINED;


Can you map nightModeStatus to the existing https://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI-property-semanticColorType property and it's Ti.UI.SEMANTIC_COLOR_TYPE_DARK + SEMANTIC_COLOR_TYPE_LIGHT type?

Those constants are used as values of Ti.UI.Android.nightModeStatus which is an Android analogue of Titanium.App.iOS.userInterfaceStyle.
I believe Titanium.App.iOS.userInterfaceStyle does not return SEMANTIC_COLOR_TYPE_DARK or SEMANTIC_COLOR_TYPE_LIGHT, does it (never checked, docs says it is String[]`)?

It returns a Number (USER_INTERFACE_STYLE_UNSPECIFIED = 0, USER_INTERFACE_STYLE_LIGHT = 1, USER_INTERFACE_STYLE_DARK = 2). So if you change the docs, it should be all set.

USER_INTERFACE_STYLE_* constants are defined in Ti.App.iOS namespace.

hansemannn · 2019-10-29T17:23:39Z

android/cli/commands/_build.js

@@ -3554,6 +3555,96 @@ AndroidBuilder.prototype.generateI18N = function generateI18N(next) {
 	next();
 };

+AndroidBuilder.prototype.generateSemanticColors = function generateSemanticColors(next) {


Does this also allow the UI to "refresh" automatically? Otherwise I wonder whats the benefit over using the existing one. Thx!

This method generates two resource-files with colors defined in them:

/res/values/semantic.colors.xml

/res/values-night/semantic.colors.xml

The goal is to be able to reuse these color in custom theme without defining them again.

Automatic "refresh" will require to restart activity (all of them), AFAIK we never do this in Titanium.

jquick-axway · 2019-10-29T18:33:07Z

FYI: We're feature freezing Titanium 8.3.0. The plan is to release 8.3.0 in the very near future.

Our current focus is "gradle" support in Titanium 9.0.0 and we don't really want any more changes that will cause merge conflicts at the moment.

Also, I think it's important that we line-up the dark/light mode handling between Android and iOS as much as possible. That may mean moving our Ti.App.iOS APIs/constants to Ti.App. The Day/Night feature is a different animal and we may need to play around with the Theme.AppCompat.DayNight style, although I'm pretty sure this can only work by having the activity destroy/recreate itself like Sergey said.

hansemannn · 2019-10-29T19:12:35Z

@jquick-axway At least for the constants, I think it's a pretty lightweight change for parity. Right now, it's already on the parity namespace (Ti.UI.*) but hardcoded to light mode on Android. If it could actually get the "real" values on the getter, it would be a quick win. @ewanharris is also into the topic.

m1ga · 2020-01-07T18:23:03Z

guess this won't make it into 9.0.0? Would be nice to have parity for the dark-mode that is already working on iOS

hansemannn · 2020-01-07T18:31:45Z

@m1ga It works well without these changes (we're not using it and have night mode support live in production).

m1ga · 2020-01-07T20:25:21Z

@hansemannn interesting. For me Ti.UI.semanticColorType is always light so I only get the light colors in fetchSemanticColor.

hansemannn · 2020-01-07T21:37:18Z

Oh, we made an own module for that (to stay SDK independent). I'll send it to you tomorrow!

drauggres · 2020-01-09T15:42:34Z

Conflicts resolved.
Branch rebased onto master.

One of the features provided by this PR is:

generate color resources from semantic.colors.json

So you will be able to use the same colors in custom theme.xml without defining them again.

- generate color resources from semantic.colors.json - add Ti.UI.Android.nightModeStatus API - add Ti.UI.Android.MODE_NIGHT_* constants refs TIMOB-27501

sgtcoolguy · 2020-05-11T13:06:10Z

Closed in favor of now-merged #11457

Thanks again @drauggres !

drauggres mentioned this pull request Oct 29, 2019

[WIP] Android "night" mode support ewanharris/darkmode-example#1

Closed

5 tasks

build added this to the 8.3.0 milestone Oct 29, 2019

build requested review from a team October 29, 2019 12:03

build added android community 🔥 docs labels Oct 29, 2019

drauggres force-pushed the TIMOB-27501 branch 3 times, most recently from 4ab4f4b to 8a52141 Compare October 29, 2019 14:44

hansemannn reviewed Oct 29, 2019

View reviewed changes

jquick-axway modified the milestones: 8.3.0, 9.0.0 Oct 29, 2019

drauggres force-pushed the TIMOB-27501 branch 2 times, most recently from 20e4b1d to 9500e22 Compare January 9, 2020 15:37

feat(android): semantic colors and night mode

b281e24

- generate color resources from semantic.colors.json - add Ti.UI.Android.nightModeStatus API - add Ti.UI.Android.MODE_NIGHT_* constants refs TIMOB-27501

drauggres force-pushed the TIMOB-27501 branch from 9500e22 to b281e24 Compare January 9, 2020 15:48

sgtcoolguy self-assigned this Jan 28, 2020

sgtcoolguy mentioned this pull request Jan 28, 2020

feat: cross-platform light/dark mode API #11457

Merged

ewanharris modified the milestones: 9.0.0, 9.1.0 Feb 12, 2020

sgtcoolguy closed this May 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(android): semantic colors and night mode #11301

feat(android): semantic colors and night mode #11301

drauggres commented Oct 29, 2019 •

edited

build commented Oct 29, 2019 •

edited

hansemannn Oct 29, 2019

drauggres Oct 29, 2019

hansemannn Oct 29, 2019

drauggres Oct 29, 2019

hansemannn Oct 29, 2019

drauggres Oct 29, 2019

jquick-axway commented Oct 29, 2019

hansemannn commented Oct 29, 2019

m1ga commented Jan 7, 2020

hansemannn commented Jan 7, 2020

m1ga commented Jan 7, 2020

hansemannn commented Jan 7, 2020

drauggres commented Jan 9, 2020

sgtcoolguy commented May 11, 2020

feat(android): semantic colors and night mode #11301

feat(android): semantic colors and night mode #11301

Conversation

drauggres commented Oct 29, 2019 • edited

build commented Oct 29, 2019 • edited

hansemannn Oct 29, 2019

Choose a reason for hiding this comment

drauggres Oct 29, 2019

Choose a reason for hiding this comment

hansemannn Oct 29, 2019

Choose a reason for hiding this comment

drauggres Oct 29, 2019

Choose a reason for hiding this comment

hansemannn Oct 29, 2019

Choose a reason for hiding this comment

drauggres Oct 29, 2019

Choose a reason for hiding this comment

jquick-axway commented Oct 29, 2019

hansemannn commented Oct 29, 2019

m1ga commented Jan 7, 2020

hansemannn commented Jan 7, 2020

m1ga commented Jan 7, 2020

hansemannn commented Jan 7, 2020

drauggres commented Jan 9, 2020

sgtcoolguy commented May 11, 2020

drauggres commented Oct 29, 2019 •

edited

build commented Oct 29, 2019 •

edited