Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fix event from already active tab in bottom style TabGroup #11304

Merged
merged 2 commits into from Apr 17, 2020
Merged

fix(android): fix event from already active tab in bottom style TabGroup #11304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c99dd2d
fix(android): fix event from already active tab in bottom style TabGroup
ypbnv Oct 30, 2019
7d2163f
Merge branch 'master' into TIMOB-27513
sgtcoolguy Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ules/ui/src/java/ti/modules/titanium/ui/widget/tabgroup/TiUIBottomNavigationTabGroup.java
View file
Open in desktop
Expand Up @@ -320,6 +320,11 @@ public boolean onMenuItemClick(MenuItem item)
{
// The controller has changed its selected item.
int index = this.mMenuItemsArray.indexOf(item);
// Guard for clicking on the currently selected tab.
// This is required to have parity with the default style tab.
if (index == this.currentlySelectedIndex) {
return true;
}
if ((index != currentlySelectedIndex) && (getProxy() != null)) {
if ((currentlySelectedIndex >= 0) && (currentlySelectedIndex < this.tabs.size())) {
TiViewProxy tabProxy = this.tabs.get(currentlySelectedIndex).getProxy();
Expand Down