-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include titanium-es api #11429
base: master
Are you sure you want to change the base?
Conversation
6d674b9
to
85a2092
Compare
90df6a2
to
ee98986
Compare
New dependencies added: titanium-esAuthor: Axway Description: Generates a modern ECMAScript wrapper for Titanium API Homepage: https://github.com/appcelerator/titanium-es#readme
|
As much I like this, please share more insights to the developers on how this affects app size and launch time performance. |
@hansemannn That's something I'm curious about too. There will be some impact, I'll be running some benchmarks soon and report my findings. |
e37174f
to
4255f5a
Compare
@garymathews As an idea: Using native V8/JSCore constructors, the whole "create" factory could be replaced easily and without wrappers. Same goes for callbacks (e.g. And SDK 9 could even log a warning that the |
@hansemannn That's the direction I want to go in, but there's parity issues doing so. iOS doesn't offer a Until there's a means of parity natively, wrapping our current Titanium API is the fastest way to achieve a modern interface. |
@garymathews iOS 13 is our friend,
=> https://nshipster.com/ios-13/ |
BTW, React Native has promises in iOS for a very long time. It's not hard to find their implementation on github. Why nobody ever talks about RN here? |
@drauggres Never used it because of performance reasons :) Also, they use a high level implementation with |
Same here. But it does not mean that we can't adopt good ideas from other projects (Native Script also looks interesting) or learn on their mistakes.
Since there is no |
Well, a low level JSCore / V8 implementation would be more performant to save bridge calls. But either way, a simple object is a good idea! |
4255f5a
to
971beb1
Compare
971beb1
to
0bc304d
Compare
WIP: DO NOT MERGE
async
await
supportTEST CASE