fix(android): module "clean" shouldn't error if missing "libs" folder #11508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When doing an "appc ti clean" in module folder, now checks if "libs" directory exists before attempting to clean it. * Titanium 9.0.0 no longer generates a "libs" folder. So, this help avoids the error.
sgtcoolguy
approved these changes
Mar 2, 2020
|
FR Passed. Module clean works fine without error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27784
Summary:
When doing module development, doing an
appc ti cleanin a module directory would error out if directory is missing a "libs" subdirectory. This can happen if you've never built the module. It will also alway happen for Titanium 9.0.0 built modules since they never produce a "libs" folder anymore. This is a minor issue that can be safely ignored since all other folders/files are correctly deleted before the task fails (it just looks bad).Test: