Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): manually evaluate all error properties (9_0_X) #11577

Merged
merged 5 commits into from
Apr 9, 2020
Merged

fix(ios): manually evaluate all error properties (9_0_X) #11577

merged 5 commits into from
Apr 9, 2020

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented Mar 30, 2020 •
edited by vijaysingh-axway

@janvennemann janvennemann added this to the 9.0.1 milestone Mar 30, 2020
@janvennemann janvennemann changed the title fix(ios): manually evaluate all error properties fix(ios): manually evaluate all error properties (9_0_X) Mar 30, 2020
@build build requested a review from a team March 30, 2020 13:47
@build
Copy link
Contributor

build commented Mar 30, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6559 tests are passing.
(There are 703 skipped tests not included in that total)

Generated by 🚫 dangerJS against e28497c

vijaysingh-axway
vijaysingh-axway approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssekhri
Copy link

ssekhri commented Apr 8, 2020

FR Passed.
Thrown error reports shown with all properties and no crash observed.
Verified on:
Mac OS: 10.15.4
SDK: 9.0.1.v20200408144306
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202003181504
Xcode: 11.4
Device: iPhone X(v13.4), iOS simulator 13.4, iOS simulator 12.2

@ssekhri ssekhri merged commit 3e06680 into tidev:9_0_X Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janvennemann @build @ssekhri @vijaysingh-axway