Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(9_0_X): amend ImageView tintColor #11696

Merged
merged 1 commit into from
May 11, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 9.0.2 milestone May 8, 2020
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build
Copy link
Contributor

build commented May 8, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 696 skipped out of 7287 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Apppause/resume events (9)5.917
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)

Generated by 🚫 dangerJS against a1e16ba

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, using the the following test case:

const win = Ti.UI.createWindow({ backgroundColor: 'white' });
const img = Ti.UI.createImageView({
width: '80%',
image: 'https://about.gitlab.com/images/press/logo/png/gitlab-icon-1-color-black-rgb.png',
tintColor: 'red'
});
 
win.add(img);
win.open();

Test Environment

MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel XL 7.1.1 

@sgtcoolguy sgtcoolguy merged commit e025e3b into tidev:9_0_X May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants