Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support semantic/named colors for color properties #11699

Merged
merged 35 commits into from
Jul 6, 2020
Merged

feat: support semantic/named colors for color properties #11699

merged 35 commits into from
Jul 6, 2020

Commits on Jul 1, 2020

  1. feat(ios): support using named colors for color properties directly 

    Fixes TIMOB-27895
    @hansemannn @sgtcoolguy
    hansemannn authored and sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    42a1faa View commit details
    Browse the repository at this point in the history

  2. feat(android): support using named colors for color properties directly

    @hansemannn @sgtcoolguy
    hansemannn authored and sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    7e3b4fa View commit details
    Browse the repository at this point in the history

  3. docs: add notes about ARGB hex format

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    915ce8f View commit details
    Browse the repository at this point in the history

  4. fix(common): assume hex is ARGB

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    41b44ff View commit details
    Browse the repository at this point in the history

  5. test: add test for direct named color property, fix alpha hex ordering

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    3bdefe0 View commit details
    Browse the repository at this point in the history

  6. fix(ios): have Ti.Color hex be AARRGGBB format (not RRGGBBAA)

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    68012ff View commit details
    Browse the repository at this point in the history

  7. feat(android): add Ti.UI.Android.getColorResource(), Ti.UI.Color 

    Also support passing color resource names to color properties
    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    ee0ad88 View commit details
    Browse the repository at this point in the history

  8. test: color resource names for Ti.UI.fetchSemanticColor, color props

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    69b78e5 View commit details
    Browse the repository at this point in the history

  9. test(android): verify Ti.UI.Android.getColorResource()

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    7634e0a View commit details
    Browse the repository at this point in the history

  10. docs(android): add Ti.UI.Android.getColorResource()

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    95e1fc6 View commit details
    Browse the repository at this point in the history

  11. docs: update Ti.UI.Color for android, fix toHex() string details

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    a555584 View commit details
    Browse the repository at this point in the history

  12. docs(ui): note that Ti.UI.fetchSemanticColor can return a String

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    0accfd1 View commit details
    Browse the repository at this point in the history

  13. test: add support for collecting generated images in tests

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    884150a View commit details
    Browse the repository at this point in the history

  14. test: add image comparison test for view with named system color as bg

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    8095daf View commit details
    Browse the repository at this point in the history

  15. test: check exact hex values of iOS system colors

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    15c40b3 View commit details
    Browse the repository at this point in the history

  16. test: support diffs for images

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    512df9e View commit details
    Browse the repository at this point in the history

  17. test: generate diff for mismatching images

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    5222ee1 View commit details
    Browse the repository at this point in the history

  18. chore: ignore test image diff directory

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    acaaa38 View commit details
    Browse the repository at this point in the history

  19. ci(jenkins): archive diff images if any

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    885a5a1 View commit details
    Browse the repository at this point in the history

  20. build(tests): use npm ci to install test dependencies

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    ab7af02 View commit details
    Browse the repository at this point in the history

  21. test: use image from ci server

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    80f9eb9 View commit details
    Browse the repository at this point in the history

  22. test: fix comparison of buffers

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    0348010 View commit details
    Browse the repository at this point in the history

  23. fix(common): copy sliced buffer doesn't extend beyond view now 

    Alos support ArrayBuffer.isView and BYTES_PER_ELEMENT sniffing pixelmatch does
    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    c22b1e3 View commit details
    Browse the repository at this point in the history

  24. test: add tests to verify fixes for Buffer

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    ee4479f View commit details
    Browse the repository at this point in the history

  25. feat(common): add basic stream shim 

    gets pngjs and browserify zlib working
    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    70c398a View commit details
    Browse the repository at this point in the history

  26. fix(buffer): add .buffer and #set to Buffer

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    6992449 View commit details
    Browse the repository at this point in the history

  27. test(buffer): add tests for Buffer .buffer and #set

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    ff1dc34 View commit details
    Browse the repository at this point in the history

  28. test: add support for grabbing diff image

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    8a9c4e1 View commit details
    Browse the repository at this point in the history

  29. test: use pngjs, pixelmatch and browserify-zlib to compare images

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    8a3841e View commit details
    Browse the repository at this point in the history

  30. style(js): don't run eslint on test fake_node_modules

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    760a1cb View commit details
    Browse the repository at this point in the history

  31. docs(android): fix typo

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    ac54ee9 View commit details
    Browse the repository at this point in the history

  32. refactor(android): just wrap ColorInt in proxy

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    73c350b View commit details
    Browse the repository at this point in the history

  33. test: port over latest changes to ti.ui.test

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    e31f0a1 View commit details
    Browse the repository at this point in the history

  34. test(android): compare hex strings from getColorResource ignoring case

    @sgtcoolguy
    sgtcoolguy committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    cbd77c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. test: use 12 x 12 view/image, otherwise ios blob pt conversion goes w… 

    …rong
    @sgtcoolguy
    sgtcoolguy committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    85011fe View commit details
    Browse the repository at this point in the history