Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): allow multiple photo selection #11867
feat(ios): allow multiple photo selection #11867
Changes from 11 commits
2f2163e
a95c6c9
b70ee42
d3760a6
7e7a263
d3cbcce
34ab3a1
42ffd02
062084a
3eff002
8be6c6a
7758f12
4a26c49
c8ea531
bafe833
2a66d3f
77b83fa
7fb1bde
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe always use it on iOS 14? The old image picker is now deprecated and should be replaced for iOS 14+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In new PHPickerViewController, there is no option for image editing(may be included in future releases). I think this is important feature and we can not remove it in minor release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are on a background thread here. Maybe validate if
closeModalPicker
andsendPickerSuccess
really are performed on the main thread. In any case, there doesn't seem to be much processing here, so is a global queue / background queue necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no special handling in this delegate method for
closeModalPicker
andsendPickerSuccess
. It is same as with old picker. Indispatch_group_notify
queue is mandatory to pass.