Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios)!: set minimum xcode to 11.x #12022

Closed
wants to merge 1 commit into from
Closed

chore(ios)!: set minimum xcode to 11.x #12022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion iphone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"minIosVersion": "10.0",
"minWatchosVersion": "2.0",
"vendorDependencies": {
"xcode": ">=9.0 <=12.x",
"xcode": ">=11.0 <=12.x",
"ios sdk": ">=10.0 <=14.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. With Xcode 11, iOAS SDK is 13. So update-
Suggested change
"ios sdk": ">=10.0 <=14.x"
"ios sdk": ">=13.0 <=14.x"
  1. As we are targeting minimus iOS SDK 13.0, we need to remove all macros IS_SDK_IOS_12 and IS_SDK_IOS_13. Because these will be irrelevant.

},
"repository": {
Expand Down