Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 9_3_X] fix(ios): guard new picker types #12024

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

build
Copy link
Contributor

@build build commented Sep 9, 2020

Backport of #12020.
See that PR for full details.

@sgtcoolguy sgtcoolguy merged commit a09a389 into tidev:9_3_X Sep 9, 2020
@build build added this to the 9.3.0 milestone Sep 9, 2020
@build build requested a review from a team September 9, 2020 13:05
@build
Copy link
Contributor Author

build commented Sep 9, 2020

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 5 tests have failed There are 5 tests failing and 719 skipped out of 8160 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientcallbackTestForGETMethod (11)60.003
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.Network.HTTPClientTIMOB-23214 (11)60.007
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.Network.HTTPClientTIMOB-23127 (11)60.012
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.WebViewblockedURLs (11)30.006
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.WebViewblacklistedURLs (11)30.008
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against dc99813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants