Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): when building module test project, unzip via spawn to avoid max buffer error #12091

Merged
merged 3 commits into from
Sep 18, 2020
Merged

fix(ios): when building module test project, unzip via spawn to avoid max buffer error #12091

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0267b5b
fix(ios): when building module test project, unzip via spawn to avoid…
sgtcoolguy Sep 16, 2020
e86b11a
Merge branch 'master' into module-unzip
sgtcoolguy Sep 17, 2020
d98c849
Merge branch 'master' into module-unzip
sgtcoolguy Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions iphone/cli/commands/_buildModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,12 +891,9 @@ iOSModuleBuilder.prototype.runModule = function runModule(next) {
);

// 5. unzip module to the tmp dir. Use native binary on macOS, as AdmZip doesn't support symlinks used in mac catalyst frameworks
exec(`unzip -o ${this.moduleZipPath} -d ${tmpProjectDir}`, (err, _stdout, _stderr) => {
if (err) {
return cb(err);
}
cb();
});
const proc = spawn('unzip', [ '-o', this.moduleZipPath, '-d', tmpProjectDir ]);
proc.once('error', err => cb(err));
proc.on('exit', () => cb());
},

function (cb) {
Expand Down