Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/clean): set prompt on project dir option #12194

Merged
merged 1 commit into from
Oct 26, 2020
Merged

fix(cli/clean): set prompt on project dir option #12194

merged 1 commit into from
Oct 26, 2020

Conversation

ewanharris
Copy link
Collaborator

This means that the prompt now gets completions for the filesystem and the titanium cli can handle
the graceful shutdown correctly

@ewanharris
fix(cli/clean): set prompt on project dir option
381b1a8 
This means that the prompt now gets completions for the filesystem and the titanium cli can handle
the graceful shutdown correctly
@ewanharris ewanharris mentioned this pull request Oct 20, 2020
Merged
@build build added this to the 9.3.0 milestone Oct 20, 2020
@build
Copy link
Contributor

build commented Oct 20, 2020

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11364 tests are passing.
(There are 1061 skipped tests not included in that total)

Generated by 🚫 dangerJS against 381b1a8

cb1kenobi
cb1kenobi approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! APPROVED!

@sgtcoolguy sgtcoolguy merged commit f5a4391 into tidev:master Oct 26, 2020
@ewanharris ewanharris deleted the set_prompt branch August 31, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ewanharris @build @cb1kenobi @sgtcoolguy