Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ios): remove debug log from toImage #12267

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

ewanharris
Copy link
Collaborator

Noticed this when using toImage, it's not a breaking change to remove it as the function signature was already changed in #9583 and this was just notifying folks

@ewanharris ewanharris added the ios label Nov 16, 2020
@ewanharris ewanharris requested a review from a team November 16, 2020 14:47
@build build added this to the 9.3.0 milestone Nov 16, 2020
@build
Copy link
Contributor

build commented Nov 16, 2020

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 9 tests have failed There are 9 tests failing and 966 skipped out of 13727 total tests.

Tests:

ClassnameNameTimeError
ios.macos.Titanium.Blobimage dimensions should be reported in pixels (10.15.7)0.047
Error: expected 6 to be 11
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.blob.test.js:483:33
ios.macos.Titanium.UI.Semantic Colorsuse semantic colors via color properties (10.15.7)0.016
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/systemredcolor_light.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.test.js:363:34
ios.macos.Titanium.UI.View.borderRadius corners1 value with shadow effect (10.15.7)0.008
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadiusWithShadow30px_1x.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1232:39
ios.macos.Titanium.UI.View.borderRadius corners1 value to create circle (10.15.7)0.006
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadius30px.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1200:39
ios.macos.Titanium.UI.View.borderRadius cornersset property post layout (10.15.7)0.005
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadius12px_12_1x.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1169:39
ios.macos.Titanium.UI.View.borderRadius corners2 values in Array (10.15.7)0.005
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadius12px_12_1x.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1135:41
ios.macos.Titanium.UI.View.borderRadius corners2 values in String (10.15.7)0.005
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadius12px_12_1x.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1101:41
ios.macos.Titanium.UI.View.borderRadius corners4 values in Array (10.15.7)0.004
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadius12px_12_12dp_12_1x.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1068:41
ios.macos.Titanium.UI.View.borderRadius corners4 values in String (10.15.7)0.008
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadius12px_12_12dp_12_1x.png
    width
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12267/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1034:41

Generated by 🚫 dangerJS against 730c729

@sgtcoolguy sgtcoolguy merged commit 9f7191d into tidev:master Nov 16, 2020
@ewanharris ewanharris deleted the remove_log branch August 31, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants