Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 9_3_X] fix(android): optimize list view updates #12405

Merged
merged 12 commits into from
Jan 21, 2021
Merged

[Backport 9_3_X] fix(android): optimize list view updates #12405

merged 12 commits into from
Jan 21, 2021

Conversation

build
Copy link
Contributor

@build build commented Jan 21, 2021

Backport of #12363.
See that PR for full details.

@build build added this to the 9.3.1 milestone Jan 21, 2021
@build build requested a review from a team January 21, 2021 18:09
@build
Copy link
Contributor Author

build commented Jan 21, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 4 tests have failed There are 4 tests failing and 914 skipped out of 13865 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Clipboard.examplesCopy Text to the Clipboard (11)0.008
Error: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference
at Context.<anonymous> (/ti.ui.clipboard.test.js:131:24)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
      at Titanium.timeslice (/ti-mocha.js:5764:23)
android.emulator.Titanium.UI.WebViewblacklistedURLs (11)41.111
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
ios.iphone.Titanium.Geolocation#reverseGeocoder() (14.0)59.998
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/0BA89FD6-590B-4E1C-A92C-C7071914B3F8/data/Containers/Bundle/Application/C7CD8FEB-72B0-4982-9F2F-A1E1F2B3C74C/mocha.app/ti-mocha.js:4290:32
ios.macos.Titanium.Blobimage dimensions should be reported in pixels (10.15.7)0.064
Error: expected 6 to be 11
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12405/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12405/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12405/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.blob.test.js:483:33

Generated by 🚫 dangerJS against 36dce00

@sgtcoolguy sgtcoolguy merged commit 23c0f6c into tidev:9_3_X Jan 21, 2021
miniman42 added a commit to miniman42/titanium_mobile that referenced this pull request Jan 27, 2021
@miniman42
Merge branch '9_3_X' into 9_3_X_GB
33da270 
* 9_3_X:
  chore(release): bump version
  docs(changelog): add 9.3.1 release notes
  chore(android): update ti.facebook to 11.0.2
  chore(ios): update facebook to 10.0.0 (tidev#12414)
  fix(ios): set statusbar height to top of safearea view (tidev#12408)
  fix(android): optimize table and list view updates (tidev#12405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@build @sgtcoolguy @garymathews