-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return Promises for async Ti.Database.DB methods #12417
Conversation
should(rows.rowCount).be.eql(1); | ||
should(rows.fieldCount).be.eql(3); | ||
should(rows.validRow).be.true(); | ||
} finally { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.database.test.js line 505 – Each then() should return a value or throw (promise/always-return)⚠️ tests/Resources/ti.database.test.js line 505 – Each then() should return a value or throw (promise/always-return)
Tests:
|
should(rows.rowCount).be.eql(1); | ||
should(rows.fieldCount).be.eql(3); | ||
should(rows.validRow).be.true(); | ||
} finally { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.database.test.js line 701 – Each then() should return a value or throw (promise/always-return)⚠️ tests/Resources/ti.database.test.js line 701 – Each then() should return a value or throw (promise/always-return)
JIRA: https://jira.appcelerator.org/browse/TIMOB-28279
Description:
Relates to #12349, #12407
This modifies some of our async methods to also return a Promise:
Ti.Database.DB.executeAsync()
Ti.Database.DB.executeAllAsync()
Unit tests are included!