Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 9_3_X] fix(android): guard scroll event section data #12434

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

build
Copy link
Contributor

@build build commented Feb 2, 2021

Backport of #12424.
See that PR for full details.

@build build added this to the 9.3.2 milestone Feb 2, 2021
@build build requested a review from a team February 2, 2021 15:55
@build
Copy link
Contributor Author

build commented Feb 2, 2021

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 6 tests have failed There are 6 tests failing and 979 skipped out of 15616 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Clipboard.examplesCopy Text to the Clipboard (11)0.119
Error: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference
at Context.<anonymous> (/ti.ui.clipboard.test.js:131:24)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
      at Titanium.timeslice (/ti-mocha.js:5764:23)
android.emulator.Titanium.UI.WebViewblacklistedURLs (11)30.003
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.WebViewuserAgent (11)39.055
Error: invalid userAgent
at WebView.<anonymous> (/ti.ui.webview.test.js:333:8)
      at WebView.value (ti:/events.js:50:21)
      at WebView.value (ti:/events.js:102:19)
ios.ipad.Titanium.UI.WebViewuserAgent (14.0)60
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/0035AEF4-D58B-4282-9C16-4D3301CDDBFC/data/Containers/Bundle/Application/5BB94D22-A705-42CA-BD4A-880E067933B0/mocha.app/ti-mocha.js:4290:32
ios.iphone.Titanium.UI.WebViewuserAgent (14.0)60.005
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/AE18703A-DF53-4174-8683-61AD6724C40C/mocha.app/ti-mocha.js:4290:32
ios.macos.Titanium.UI.WebViewuserAgent (10.15.7)60.091
Error: timeout of 60000ms exceeded
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12434/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against 1386fce

@sgtcoolguy sgtcoolguy merged commit a92bea2 into tidev:9_3_X Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants