Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): amend child event ListView properties #12460

Merged
merged 3 commits into from
Feb 10, 2021
Merged

fix(android): amend child event ListView properties #12460

merged 3 commits into from
Feb 10, 2021

Conversation

build
Copy link
Contributor

@build build commented Feb 10, 2021

Backport of #12456.
See that PR for full details.

@build build added this to the 9.3.2 milestone Feb 10, 2021
@build build requested a review from a team February 10, 2021 01:30
@build
Copy link
Contributor Author

build commented Feb 10, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 5 tests have failed There are 5 tests failing and 900 skipped out of 13744 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.Media.VideoPlayerClose window containing a video player (TIMOB-25574) (14.4)26.702
Error: timeout of 15000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4290:32
ios.ipad.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)0.999
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:5764:29
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.357
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/F076B618-B8D0-47DB-95C9-67AF498513DB/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.746
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.522
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/756EA0F1-F601-4DF8-8E68-4F40BF802C48/data/Containers/Bundle/Application/AAB05F5B-77B2-46F7-85F3-B183FFBE1591/mocha.app/ti-mocha.js:5764:29

Generated by 🚫 dangerJS against 879bb4a

@ewanharris ewanharris changed the title [Backport 9_3_X] fix(android): amend child event ListView properties fix(android): amend child event ListView properties Feb 10, 2021
@ewanharris ewanharris merged commit 0935358 into tidev:9_3_X Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@build @ewanharris @garymathews