Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): documentViewer setAnnotation method causing a crash #12496

Merged
merged 10 commits into from
Mar 17, 2021
Merged

fix(ios): documentViewer setAnnotation method causing a crash #12496

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b831599
fix(ios): documentViewer setAnnotation method causing a crash
vijaysingh-axway Feb 24, 2021
31eb71f
Merge branch 'master' into TIMOB-28360
vijaysingh-axway Mar 1, 2021
8536db2
test(ios): added unit test
vijaysingh-axway Mar 10, 2021
c5446bc
test(ios): reemoved unnecessary code
vijaysingh-axway Mar 10, 2021
574c71c
test(ios): add documentviewer unit test
vijaysingh-axway Mar 11, 2021
a8c97cd
Merge branch 'master' into TIMOB-28360
vijaysingh-axway Mar 11, 2021
989de61
Merge branch 'master' into TIMOB-28360
vijaysingh-axway Mar 11, 2021
af94216
test(ios): skip test for mac
vijaysingh-axway Mar 12, 2021
bca64f5
fix(ios): addressed review comment
vijaysingh-axway Mar 15, 2021
6dab5a3
Merge branch 'master' into TIMOB-28360
vijaysingh-axway Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions apidoc/Titanium/UI/iOS/DocumentViewer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ properties:
the API summary.
type: String

- name: annotation
summary: Custom property list information for the target file.
description: |
Use this property to pass information about the document type to the app responsible for opening it.
type: [Dictionary, Array, String, Number, Date]

methods:
- name: hide
summary: Dismisses the document viewer.
Expand Down
2 changes: 1 addition & 1 deletion iphone/Classes/TiUIiOSDocumentViewerProxy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ - (NSString *)apiName

- (void)setAnnotation:(id)args
{
[self controller].annotation = [args objectAtIndex:0];
[self controller].annotation = args;
}

- (void)show:(id)args
Expand Down