Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 9_3_X] fix(ios): documentViewer setAnnotation method causing a crash #12610

Merged
merged 7 commits into from
Mar 17, 2021
Merged

[Backport 9_3_X] fix(ios): documentViewer setAnnotation method causing a crash #12610

merged 7 commits into from
Mar 17, 2021

Conversation

build
Copy link
Contributor

@build build commented Mar 17, 2021

Backport of #12496.
See that PR for full details.

@build build requested review from a team March 17, 2021 14:56
@build
Copy link
Contributor Author

build commented Mar 17, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 7 tests have failed There are 7 tests failing and 898 skipped out of 12760 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation#forwardGeocoder() (11)51.001
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:313:32)
android.emulator.Titanium.UI.Clipboard.examplesCopy Text to the Clipboard (11)0.008
Error: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference
at Context.<anonymous> (/ti.ui.clipboard.test.js:131:24)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
      at Titanium.timeslice (/ti-mocha.js:5764:23)
ios.ipad.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)0.955
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped@2x~ipad.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:5764:29
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.345
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/6FAD9729-9B79-4523-B14E-B4BF98C5858C/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.324
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.427
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/52B04666-7557-4409-BA64-1308CFE575EA/mocha.app/ti-mocha.js:5764:29
ios.macos.Titanium.UI.Semantic Colorsuse semantic colors via color properties (10.15.5)0.095
Error: expected 'Ti.UI.View' to match image ('snapshots/systemredcolor_light.png')
    expected 12 to be 6
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12610/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12610/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12610/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.test.js:363:34

Generated by 🚫 dangerJS against 5900395

@sgtcoolguy
Copy link
Contributor

Due to mocha change, this doesn't apply cleanly (the this.skip() calls in the unit test)

@sgtcoolguy sgtcoolguy self-assigned this Mar 17, 2021
@sgtcoolguy sgtcoolguy merged commit df62673 into tidev:9_3_X Mar 17, 2021
@sgtcoolguy sgtcoolguy deleted the backport-12496-to-9_3_X branch March 17, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgtcoolguy sgtcoolguy

Labels
docs ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@build @sgtcoolguy @vijaysingh-axway